Add XdsDirectory to get d2 service and cluster names from INDIS #1038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a4f1ac1 to
ef522ff
Compare
PapaCharlie
requested changes
Jan 17, 2025
d2/src/main/java/com/linkedin/d2/xds/balancer/XdsDirectory.java
Outdated
Show resolved
Hide resolved
d2/src/main/java/com/linkedin/d2/xds/balancer/XdsDirectory.java
Outdated
Show resolved
Hide resolved
d2/src/main/java/com/linkedin/d2/xds/balancer/XdsDirectory.java
Outdated
Show resolved
Hide resolved
d2/src/main/java/com/linkedin/d2/xds/balancer/XdsDirectory.java
Outdated
Show resolved
Hide resolved
PapaCharlie
reviewed
Jan 21, 2025
d2/src/main/java/com/linkedin/d2/xds/balancer/XdsDirectory.java
Outdated
Show resolved
Hide resolved
d2/src/main/java/com/linkedin/d2/xds/balancer/XdsDirectory.java
Outdated
Show resolved
Hide resolved
PapaCharlie
requested changes
Jan 23, 2025
d2/src/main/java/com/linkedin/d2/xds/balancer/XdsDirectory.java
Outdated
Show resolved
Hide resolved
d2/src/main/java/com/linkedin/d2/xds/balancer/XdsDirectory.java
Outdated
Show resolved
Hide resolved
d2/src/main/java/com/linkedin/d2/xds/balancer/XdsDirectory.java
Outdated
Show resolved
Hide resolved
PapaCharlie
requested changes
Jan 23, 2025
brycezhongqing
approved these changes
Jan 27, 2025
…nd unlock write lock after checking isUpdating flag
d2/src/main/java/com/linkedin/d2/xds/balancer/XdsDirectory.java
Outdated
Show resolved
Hide resolved
d2/src/main/java/com/linkedin/d2/xds/balancer/XdsDirectory.java
Outdated
Show resolved
Hide resolved
PapaCharlie
reviewed
Jan 29, 2025
d2/src/main/java/com/linkedin/d2/xds/balancer/XdsDirectory.java
Outdated
Show resolved
Hide resolved
d2/src/main/java/com/linkedin/d2/xds/balancer/XdsDirectory.java
Outdated
Show resolved
Hide resolved
d2/src/main/java/com/linkedin/d2/xds/balancer/XdsDirectory.java
Outdated
Show resolved
Hide resolved
PapaCharlie
approved these changes
Jan 29, 2025
PapaCharlie
approved these changes
Jan 29, 2025
PapaCharlie
added a commit
to linkedin/diderot
that referenced
this pull request
Feb 7, 2025
Because there is no explicit provision for unknown resource types in the xDS protocol, the server implementation had to make a bunch of assumptions about how it should respond. These assumptions incidentally violated the xDS protocol NACK/ACK flow. Instead, the behavior should be handed off to the `ResourceLocator` implementation so that it can decide what to do. This also allows the simplification of the `ResourceLocator` interface, which is an added benefit. Note that this change is backwards incompatible, so will need to be bumped carefully. I have tested this manually using the bad version of rest.li which triggered this loop (linkedin/rest.li#1038), and can confirm that this behavior is fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Support getting d2 service and cluster name lists from INDIS with Xds load balancer. This is needed by some apps (like d2-proxy) that need to read the names to migrate to INDIS read.
Note that observer hasn't supported the resource D2ClusterOrServiceName yet, so build and test are failing.
Test
UT. QEI test with d2-proxy. The names is fetched and served correctly.