Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor testing frameworks #658

Merged
merged 7 commits into from
May 7, 2015
Merged

Refactor testing frameworks #658

merged 7 commits into from
May 7, 2015

Conversation

sethkinast
Copy link
Contributor

  • Remove uutest and all the custom code in favor of jasmine
    • Rewrote core specs; much easier to add new tests
  • Remove rhino JARs from our repo and depend on them instead in package.json
  • Remove legacy Node scripts and replace them with Grunt tasks
  • Refactor testing directory structure; much flatter now

I'm almost at a place where I feel pretty good about Dust testing.

Seth Kinast added 6 commits May 4, 2015 19:17
Remove .npmignore
4db1034 
NPM ignores .gitignore by default if no .npmignore is present.

We want people to be able to npm install dust and do dev on it without having to git clone
Depend on Rhino packages instead of including them with the Dust repo.
f154462 
Closes linkedin#602
Gruntfile cruft
bc1dd7d
render tests work with jasmine
01062d0
Remove uutest and refactor test directory structure
deb0f35
Modernize old non-grunt tasks to use grunt tasks
801a3e0 
* grunt-peg replaces build.js
* grunt-execute replaces grunt-shell
@sethkinast
Copy link
Contributor Author

Closes #649 too

@sethkinast
Copy link
Contributor Author

And closes #602

@sethkinast
Copy link
Contributor Author

And closes #642

sethkinast added a commit that referenced this pull request May 7, 2015
@sethkinast
Merge pull request #658 from sethkinast/burn-uutest
b5e4fb6 
Refactor testing frameworks

Closes #649 
Closes #602 
Closes #642
@sethkinast sethkinast merged commit b5e4fb6 into linkedin:master May 7, 2015
@sethkinast sethkinast deleted the burn-uutest branch May 7, 2015 20:18
@snyk-bot snyk-bot mentioned this pull request Jan 22, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sethkinast @jimmyhchan