escape values when using json filter #540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| name: "escapeJSON filter with bad characters", | ||
| source: "{obj|js|s}", | ||
| context: { obj: { name: "<<\u2028testLS \u2029testPS"} }, | ||
| expected: '{"name":"<<\\u2028testLS \\u2029testPS"}', |
There was a problem hiding this comment.
This seems non-ideal. Now there's no way for me to get angle bracket literals when using |js, even if I explicitly say I want to turn off HTML escaping.
There was a problem hiding this comment.
ahhh.. that's cause i did it wrong... it should have been replaced with \u003c
65141f5 to
f2dc19c
Compare
|
Ahh, that's better. Yeah, this seems reasonable to me. Anywhere you are using 👍 from me |
prashn64
added a commit
that referenced
this pull request
Feb 10, 2015
escape values (\u2028, \u2029 and <) when using json filter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since most templates write into html context or worse, a script tag, let's add a few extra characters to escape.
slight refactor to expose a
dust.escapeJSONmethod