remove the globals and isolate parser and compiler #382
Conversation
…obal and explicitly show where parser and compiler go in the global dust namespace
| if (typeof exports === 'object') { | ||
| module.exports = factory(require('./parser').parse, require('./dust')); | ||
| } else { | ||
| var compiler = factory(root.dust.parse, root.dust); |
There was a problem hiding this comment.
Looks like var compiler is local variable not used anywhere. Do we need to define it here?
There was a problem hiding this comment.
Yeah. good catch. It meant it as a self documenting thing to show that if we require('./lib/compiler') in Node (line 4) we decorate the dust object as well as module.exports a compiler object. This is similar on the browser. When we include the lib/compiler file we are decorating the dust object with compiler methods but then we throwout the compiler reference.
There's some symmetry that helped me try to clean up the dependency soup here but it is not necessary... though I find it hard to get rid of it
|
Looks good to me as long as this still works in Rhino. Right now all of the unit tests run in node, we also have client side testing. But as far as I know no Rhino testing. Maybe we could set up some testing in Rhino as well (not as part of this PR but perhaps as a separate issue). |
…ectory and comment that the parser file is generated
remove the globals and isolate parser and compiler
A bunch of cleanup. The jshint fixes revealed there are a bunch of globals
etc.