Issue #340. Remove old optimization to avoid looking at arrays in get. #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s in get. We need to look for
|
LGTM. We should merge this. |
smfoote
added a commit
that referenced
this pull request
Nov 26, 2013
Issue #340. Remove old optimization to avoid looking at arrays in get.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #340
Original code (pre $idx) tried to optimize get by not checking for value when an array was at the head. With the addition of $idx, this "optimization" breaks a use case. Removing the array check when creating a Stack entry fixes the problem by allowing get to go ahead and discover the $idx value on the stack. Added a test for the reported problem.