Escape a single quote apostrophe in escapeHtml #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -459,14 +459,15 @@ var HCHARS = new RegExp(/[&<>\"]/), | |||
There was a problem hiding this comment.
we need it in the HCHARS too? is it not ?
unit tests pass, so I am not sure.
There was a problem hiding this comment.
Haha, I did have it in there before I stashed and lost my changes on
another branch.
Check it now, I added some code.
Thanks for catching it :-)
On Wed, May 16, 2012 at 10:37 PM, Veena Basavaraj <
reply@reply.github.com
wrote:
@@ -459,14 +459,15 @@ var HCHARS = new RegExp(/[&<>"]/),
we need it in the HCHARS too.
I did the same mistake before; )
Reply to this email directly or view it on GitHub:
https://github.com/linkedin/dustjs/pull/34/files#r836841
Johnathan
Software Engineer
San Francisco, California
Follow me on Twitter: @iamleppert http://twitter.com/#!/iamleppert
vybs
added a commit
that referenced
this pull request
May 21, 2012
Escape a single quote apostrophe in escapeHtml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added escaping for single quotes and updated tests. fixes #24