Fix Issue #322. block name in template includes previous text by mistake #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (typeof key === "function") { | ||
| saveData = chk.data; | ||
| chk.data = []; |
There was a problem hiding this comment.
We are only using the chunk for it's API.
can we instead just do:
var tempChk = new Chunk();
if (typeof key==='function') {
key = key(tempChk, this).data.join('');
}
we don't need to pass in ctx since this is the context
|
Looks good. pull when ready! |
rragan
added a commit
that referenced
this pull request
Aug 29, 2013
Fix Issue #322. block name in template includes previous text by mistake
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing code ends up including text already in the chunk as part of the name of the block definition in a base template. Fix is to save away the existing text in the chunk, clear out the chunk data, collect the block name by calling the function and then restore whatever data was in the chunk from before.