Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

silent corruption and unrecoverably data loss with non-ascii (e.g. Unicode) characters #10

Closed
clach04 opened this issue May 22, 2022 · 0 comments

Comments

@clach04
Copy link
Contributor

clach04 commented May 22, 2022

On any platform where default encoding is not utf-8 (e..g linux with C locale, or Microsoft Windows) corruption that can not be recovered from occurs.

Sample file content:

7bit ascii filename unicode content

This file will fail to save, no meaningful information logged to stdout.
Default logfile only indicates note id, not title/filename, example:

    2022-05-21 21:55:23,683 [ERROR] Error writing note: f3902b0e-07ef-4e6f-9896-2a23c1e9ca52

suqsequent sync will then upload empty file and server will loose history.
Will not show up in trash and history (restore) option is missing :-(

Copy/paste https://emojipedia.org/skull-and-crossbones/ below
☠️

3 issues probably need to be corrected to address:

  • error handling needs to be more robust and vocal
  • refactor code to remove duplicate file writing code
  • explicitly define (file) encoding
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant