Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#587: Optional line numbers for lingui format #588

Merged
merged 3 commits into from
Dec 2, 2019

Conversation

MarttiR
Copy link
Contributor

@MarttiR MarttiR commented Nov 14, 2019

Adds configuration object formatOptions with key origins. The object is passed to the format's write() in the third param.

To turn off line numbers in catalogue files, configure .linguirc as follows:

"formatOptions": {
  "origins": false
}

@vercel
Copy link

vercel bot commented Nov 14, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click on the icon next to each commit.

@vercel vercel bot requested a deployment to staging November 14, 2019 10:56 Abandoned
@vercel
Copy link

vercel bot commented Nov 14, 2019

Deployment failed with the following error:

Your `package.json` file is missing a `build` property inside the `script` property.

@MarttiR
Copy link
Contributor Author

MarttiR commented Nov 14, 2019

#587

@vercel vercel bot requested a deployment to staging November 14, 2019 12:24 Abandoned
@vercel
Copy link

vercel bot commented Nov 14, 2019

Deployment failed with the following error:

Your `package.json` file is missing a `build` property inside the `script` property.

@tricoder42
Copy link
Contributor

Hey @MarttiR, thank you, this looks good indeed!

Don't mind the failing tests, the failing ones are unrelated to this PR. Could you please fix the linter error? You just need to add origin prop to LinguiConfig type (I think it's in @lingui/conf package)

Thanks a lot!

@vercel vercel bot requested a deployment to staging November 29, 2019 15:53 Abandoned
@vercel
Copy link

vercel bot commented Nov 29, 2019

Deployment failed with the following error:

Your `package.json` file is missing a `build` property inside the `script` property.

@tricoder42 tricoder42 merged commit b1a109a into lingui:master Dec 2, 2019
@tricoder42
Copy link
Contributor

Perfect, thank you!

@gothy
Copy link
Contributor

gothy commented Dec 2, 2019

@MarttiR thank you very much for this one 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants