Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update babel #1396

Merged
merged 1 commit into from
Feb 3, 2023
Merged

Conversation

timofei-iatsenko
Copy link
Collaborator

@timofei-iatsenko timofei-iatsenko commented Feb 2, 2023

Description

Porting non-breaking changes from #1367
Update babel to latest 7.20.

The test fixtures in macro/test was updated because of newer babel/generator. Looks like newer version generates slightly different output in terms of whitespaces. This not affect logic anyhow, only formatting.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Fixes # (issue)

Checklist

  • I have read the CONTRIBUTING and CODE_OF_CONDUCT docs
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Feb 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
js-lingui ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 3, 2023 at 11:04AM (UTC)

@github-actions
Copy link

github-actions bot commented Feb 2, 2023

size-limit report 📦

Path Size
./packages/core/build/esm/index.js 2.89 KB (0%)
./packages/detect-locale/build/esm/index.js 804 B (0%)
./packages/react/build/esm/index.js 2.61 KB (0%)
./packages/remote-loader/build/esm/index.js 7.36 KB (0%)

@timofei-iatsenko timofei-iatsenko marked this pull request as draft February 2, 2023 18:53
@timofei-iatsenko timofei-iatsenko marked this pull request as ready for review February 2, 2023 19:07
@codecov
Copy link

codecov bot commented Feb 2, 2023

Codecov Report

Base: 82.80% // Head: 82.80% // No change to project coverage 👍

Coverage data is based on head (15ba364) compared to base (6a90cb9).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1396   +/-   ##
=======================================
  Coverage   82.80%   82.80%           
=======================================
  Files          66       66           
  Lines        1756     1756           
  Branches      487      487           
=======================================
  Hits         1454     1454           
  Misses        174      174           
  Partials      128      128           
Impacted Files Coverage Δ
packages/macro/test/js-arg.ts 100.00% <ø> (ø)
packages/macro/test/js-plural.ts 100.00% <ø> (ø)
packages/macro/test/js-select.ts 100.00% <ø> (ø)
packages/macro/test/js-selectOrdinal.ts 100.00% <ø> (ø)
packages/macro/test/js-t.ts 100.00% <ø> (ø)
packages/macro/test/jsx-trans.ts 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@andrii-bodnar
Copy link
Contributor

It's great that we can decouple this part as a separate PR 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants