fix: stripping origin if line numbers already strippped (#1143)

packages/cli/src/api/catalog.ts

@@ -21,7 +21,7 @@ const LOCALE = "{locale}"
 const LOCALE_SUFFIX_RE = /\{locale\}.*$/
 const PATHSEP = "/" // force posix everywhere
 
-type MessageOrigin = [string, number]
+type MessageOrigin = [string, number?]
 
 export type ExtractedMessageType = {
   message?: string

packages/cli/src/api/formats/po-gettext.ts

@@ -65,7 +65,7 @@ const serialize = (items: CatalogType, options) =>
 
       if (options.origins !== false) {
         if (message.origin && options.lineNumbers === false) {
-          item.references = message.origin.map(msg => msg.slice(0, -1)).map(joinOrigin)
+          item.references = message.origin.map(([path]) => path);
         } else {
           item.references = message.origin ? message.origin.map(joinOrigin) : []
         }

packages/cli/src/api/formats/po.test.ts

@@ -266,4 +266,60 @@ describe("pofile format", () => {
 
     `)
   })
+
+  it("should not include lineNumbers if lineNumbers option is false and already excluded", () => {
+    mockFs({
+      locale: {
+        en: mockFs.directory(),
+      },
+    })
+
+    const filename = path.join("locale", "en", "messages.po")
+    const catalog: CatalogType = {
+      static: {
+        translation: "Static message",
+      },
+      withOrigin: {
+        translation: "Message with origin",
+        origin: [["src/App.js"]],
+      },
+      withMultipleOrigins: {
+        translation: "Message with multiple origin",
+        origin: [
+          ["src/App.js"],
+          ["src/Component.js"],
+        ],
+      },
+    }
+    format.write(filename, catalog, {
+      origins: true,
+      lineNumbers: false,
+      locale: "en",
+    })
+    const pofile = fs.readFileSync(filename).toString()
+    mockFs.restore()
+    expect(pofile).toMatchInlineSnapshot(`
+      msgid ""
+      msgstr ""
+      "POT-Creation-Date: ${formatDate(new Date(), "yyyy-MM-dd HH:mmxxxx")}\\n"
+      "MIME-Version: 1.0\\n"
+      "Content-Type: text/plain; charset=utf-8\\n"
+      "Content-Transfer-Encoding: 8bit\\n"
+      "X-Generator: @lingui/cli\\n"
+      "Language: en\\n"
+
+      msgid "static"
+      msgstr "Static message"
+
+      #: src/App.js
+      msgid "withOrigin"
+      msgstr "Message with origin"
+
+      #: src/App.js
+      #: src/Component.js
+      msgid "withMultipleOrigins"
+      msgstr "Message with multiple origin"
+
+    `)
+  })
 })

packages/cli/src/api/formats/po.ts

@@ -27,7 +27,7 @@ const serialize = (items: CatalogType, options) =>
       item.extractedComments = message.extractedComments || []
       if (options.origins !== false) {
         if (message.origin && options.lineNumbers === false) {
-          item.references = message.origin.map(msg => msg.slice(0, -1)).map(joinOrigin)
+          item.references = message.origin.map(([path]) => path);
         } else {
           item.references = message.origin ? message.origin.map(joinOrigin) : []
         }