Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removes CardManyToMany #1

Merged
merged 2 commits into from
Oct 29, 2021
Merged

removes CardManyToMany #1

merged 2 commits into from
Oct 29, 2021

Conversation

owen-d
Copy link

@owen-d owen-d commented Oct 28, 2021 •
edited
Loading

Removes CardManyToMany, which added unnecessary complexity. I also found this to be more "correct" as

<expr> <logical|set-op> <expr>

is actually a one-to-one match, not a many to many. Instead, this always treats logical|set operators as one-to-one implicitly.

@owen-d owen-d mentioned this pull request Oct 28, 2021
Merged
2 tasks
lingpeng0314
lingpeng0314 approved these changes Oct 29, 2021
View reviewed changes
Copy link
Owner

@lingpeng0314 lingpeng0314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lingpeng0314 lingpeng0314 merged commit 96a6e98 into lingpeng0314:group_left_right Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lingpeng0314 lingpeng0314 lingpeng0314 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@owen-d @lingpeng0314