Pin the version of the base64ct indirect dependency
#3420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version 1.7.0 breaks semver compatibility by requiring the usage of a new Rust edition.
0dbf02b to
fd1ab31
Compare
afck
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Version 1.7.0 breaks semver compatibility by requiring the usage of a new Rust edition. More information is available in RustCrypto/formats#1684.
Proposal
We should pin it to the last version that we still support at least until we manage to update to the new Rust edition.
Test Plan
CI should catch any regressions.
Release Plan
We may have to make a new SDK release with a new patch version.
Links