Use owners instead of public keys. #3160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3d6b992 to
f4c5f3f
Compare
f4c5f3f to
0d6d990
Compare
christos-h
approved these changes
Jan 22, 2025
| pub fn verify_owner(&self, proposal: &BlockProposal) -> Option<PublicKey> { | ||
| if let Some(public_key) = self.ownership.get().super_owners.get(&proposal.owner) { | ||
| return Some(*public_key); | ||
| pub fn verify_owner(&self, proposal: &BlockProposal) -> bool { |
There was a problem hiding this comment.
Need to update method description here?
ma2bd
reviewed
Jan 22, 2025
| @@ -124,6 +124,8 @@ BlockProposal: | |||
| TYPENAME: ProposalContent | |||
| - owner: | |||
| TYPENAME: Owner | |||
| - public_key: | |||
ma2bd
approved these changes
Jan 22, 2025
bart-linera
added a commit
to bart-linera/linera-protocol
that referenced
this pull request
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
For #3162 we need to stop using
ChainOwnershipas a lookup table for public keys.In general, we are using
PublicKeyin several places where we should be using theOwnertype.Proposal
Remove public keys from
ChainOwnership. Add the signer's public key directly to theBlockProposalinstead.When creating key pairs, assigning chains and changing chain ownership via CLI commands, node service mutations or system API calls, use
Ownerinstead ofPublicKey.Test Plan
Several tests have been updated.
Release Plan
Links
PublicKeyfromChainOwnership. #3165.