Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --no-fail-fast to CI testing. #738

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Add --no-fail-fast to CI testing. #738

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,10 @@ env:
# Using cargo-hack also allows us to more easily test the feature matrix of our packages.
# We use --each-feature & --optional-deps which will run a separate check for every feature.
#
# We use cargo-nextest, which has a faster concurrency model for running tests.
# However cargo-nextest does not support running doc tests, so we also have a cargo test --doc step.
# For more information see https://github.com/nextest-rs/nextest/issues/16
#
# The MSRV jobs run only cargo check because different clippy versions can disagree on goals and
# running tests introduces dev dependencies which may require a higher MSRV than the bare package.
#
Expand Down Expand Up @@ -242,7 +246,7 @@ jobs:
sudo apt-get update
sudo apt install -y xvfb libegl1-mesa libgl1-mesa-dri libxcb-xfixes0-dev mesa-vulkan-drivers

- name: Install cargo-nextest
- name: install cargo-nextest
uses: taiki-e/install-action@v2
with:
tool: cargo-nextest
Expand All @@ -252,15 +256,10 @@ jobs:
with:
save-if: ${{ github.event_name != 'merge_group' }}

- name: cargo test
run: cargo nextest run --workspace --locked --all-features
- name: cargo nextest
run: cargo nextest run --workspace --locked --all-features --no-fail-fast
env:
SKIP_RENDER_TESTS: ${{ matrix.skip_gpu }}

# Run doc tests separately because nexttest doesn't run them.
# See https://github.com/linebender/xilem/issues/500
- name: cargo test doc
run: cargo test --doc --workspace --locked --all-features

- name: Upload test results due to failure
uses: actions/upload-artifact@v4
Expand All @@ -269,6 +268,9 @@ jobs:
name: masonry-snapshot-tests-${{ matrix.os }}
path: masonry/src/widget/screenshots

- name: cargo test --doc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. We likely do want these to produce screenshots - see #501.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, it won't be a big task to move it if it makes sense with the new screenshot implementation. As for right now, it looks like we don't even have an implementation, so the details may change.

run: cargo test --doc --workspace --locked --all-features --no-fail-fast

test-stable-wasm:
name: cargo test (wasm32)
runs-on: ubuntu-latest
Expand Down