Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: Update wgpu, vello, peniko #381

Merged
merged 1 commit into from
Jun 10, 2024
Merged

deps: Update wgpu, vello, peniko #381

merged 1 commit into from
Jun 10, 2024

Conversation

waywardmonkeys
Copy link
Contributor

This brings us to the 0.2 release of Vello, which brings the 0.20 release of wgpu.

@waywardmonkeys
deps: Update wgpu, vello, peniko
870c0f4 
This brings us to the 0.2 release of Vello, which brings the 0.20
release of wgpu.
@waywardmonkeys waywardmonkeys requested a review from DJMcNab June 10, 2024 03:35
DJMcNab
DJMcNab approved these changes Jun 10, 2024
View reviewed changes
Copy link
Member

@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'm seeing some slightly slow startup times on desktop, but it's much improved on Android. And it seems like this startup time issue is also present on main.

@waywardmonkeys
Copy link
Contributor Author

I feel like that changed recently. I don't recall the startup white flash on my machine before, but it is definitely there now and without these changes.

@waywardmonkeys waywardmonkeys added this pull request to the merge queue Jun 10, 2024
Merged via the queue into linebender:main with commit 1ddff7b Jun 10, 2024
8 checks passed
@waywardmonkeys waywardmonkeys deleted the update-vello-wgpu-peniko branch June 10, 2024 08:36
@DJMcNab DJMcNab mentioned this pull request Jun 10, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Jun 10, 2024
@DJMcNab
Add milliseconds in the tracing formatting (#383)
8386ad2 
In #254, we had an initial log format added.

However, that doesn't include support for milliseconds, which are useful
in a GUI system because it allows getting a first approximation of
latency. I'm adding this now because of the startup latency issues first
observed in #381 ([#masonry > Slight Startup Time
Regression](https://xi.zulipchat.com/#narrow/stream/317477-masonry/topic/Slight.20Startup.20Time.20Regression))
@DJMcNab DJMcNab mentioned this pull request Jun 11, 2024
Closed
@RagibHasin RagibHasin mentioned this pull request Aug 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DJMcNab DJMcNab DJMcNab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@waywardmonkeys @DJMcNab