Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Render COLR Glyphs (Emoji) #615

Merged
merged 14 commits into from
Jun 21, 2024
Merged

Render COLR Glyphs (Emoji) #615

merged 14 commits into from
Jun 21, 2024

Conversation

DJMcNab
Copy link
Member

@DJMcNab DJMcNab commented Jun 18, 2024 •
edited
Loading

This is following the breadcrumbs laid out in #gpu > Emoji Rendering

This supports rendering COLR emoji; we assume that these are reasonably well behaved.
image

For examples, we use a very small subset of Noto Color Emoji, which is approximately 5.5kB.

Fixes #536

We will need a follow up issue for sbix/CBDT. I presume we're ignoring svg-in-opentype.

@dfrg
Copy link
Collaborator

dfrg commented Jun 19, 2024

Yes, this is looking good so far. Note that you’ll need to grab the CPAL table to resolve palette indices to actual colors. We don’t do this by default because we need to allow custom overrides by index for the web.

Thanks for taking this on!

@DJMcNab
Copy link
Member Author

DJMcNab commented Jun 19, 2024

image

@DJMcNab DJMcNab requested a review from dfrg June 19, 2024 14:09
DJMcNab
DJMcNab commented Jun 19, 2024
View reviewed changes
Copy link
Member Author

@DJMcNab DJMcNab left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments for reviewers

examples/scenes/src/simple_text.rs Outdated Show resolved Hide resolved
vello/src/scene.rs Outdated Show resolved Hide resolved
vello/src/scene.rs Outdated Show resolved Hide resolved
@DJMcNab DJMcNab changed the title Experimental Emoji rendering Rendering of some Emoji Jun 19, 2024
dfrg
dfrg reviewed Jun 20, 2024
View reviewed changes
examples/scenes/src/simple_text.rs Outdated Show resolved Hide resolved
vello/src/scene.rs Outdated Show resolved Hide resolved
vello/src/scene.rs Outdated Show resolved Hide resolved
vello/src/scene.rs Outdated Show resolved Hide resolved
vello/src/scene.rs Outdated Show resolved Hide resolved
vello/src/scene.rs Outdated Show resolved Hide resolved
vello/src/scene.rs Show resolved Hide resolved
vello/src/scene.rs Show resolved Hide resolved
@DJMcNab DJMcNab requested a review from dfrg June 21, 2024 10:55
@DJMcNab DJMcNab changed the title Rendering of some Emoji Render COLR Glyphs/Emoji Jun 21, 2024
dfrg
dfrg approved these changes Jun 21, 2024
View reviewed changes
Copy link
Collaborator

@dfrg dfrg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Daniel! This covers a lot of ground and is a great foundation for full emoji support.

vello/src/scene.rs Outdated Show resolved Hide resolved
DJMcNab and others added 3 commits June 21, 2024 16:15
@DJMcNab @dfrg
Remove debug print
6f3f6de 
Co-Authored-By: Chad Brokaw <cbrokaw@gmail.com>
@DJMcNab
Fixup comments
ac2e623
@DJMcNab
Fix coordinates and some small details
d7519c5 
Make `try_draw_colr` not public
Add some docs
@DJMcNab DJMcNab changed the title Render COLR Glyphs/Emoji Render COLR Glyphs (Emoji) Jun 21, 2024
@DJMcNab DJMcNab enabled auto-merge June 21, 2024 15:32
@DJMcNab DJMcNab added this pull request to the merge queue Jun 21, 2024
Merged via the queue into linebender:main with commit 886604b Jun 21, 2024
16 checks passed
@DJMcNab DJMcNab deleted the emojish branch June 21, 2024 15:41
@DJMcNab DJMcNab mentioned this pull request Jun 25, 2024
Closed
@DJMcNab DJMcNab mentioned this pull request Jul 1, 2024
Open
@waywardmonkeys waywardmonkeys added this to the Vello 0.3 release milestone Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfrg dfrg dfrg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Vello 0.3 release
Development

Successfully merging this pull request may close these issues.

Trouble drawing emojis
3 participants
@DJMcNab @dfrg @waywardmonkeys