Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixup clippy lints for 1.40 #406

Merged
merged 1 commit into from
Dec 20, 2019
Merged

Fixup clippy lints for 1.40 #406

merged 1 commit into from
Dec 20, 2019

Conversation

cmyr
Copy link
Member

@cmyr cmyr commented Dec 20, 2019

No description provided.

raphlinus
raphlinus approved these changes Dec 20, 2019
View reviewed changes
druid/src/widget/list.rs Outdated Show resolved Hide resolved
@cmyr cmyr force-pushed the clippy-fixes-1.40 branch from a467666 to 58a6334 Compare December 20, 2019 17:17
@raphlinus raphlinus mentioned this pull request Dec 20, 2019
Closed
@cmyr cmyr force-pushed the clippy-fixes-1.40 branch from 58a6334 to ab8e27a Compare December 20, 2019 17:38
raphlinus
raphlinus approved these changes Dec 20, 2019
View reviewed changes
Copy link
Contributor

@raphlinus raphlinus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! If we start exposing some of the druid-shell internals as platform-specific escape hatches, we'll want to document safety, but we should be getting the lints.

druid-shell/src/platform/windows/mod.rs Outdated
@@ -14,6 +14,8 @@

//! Windows implementation of druid-shell.

#![allow(clippy::missing_safety_doc)]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was left in by mistake; it's clean without.

@cmyr cmyr merged commit 942e9d1 into master Dec 20, 2019
@cmyr cmyr deleted the clippy-fixes-1.40 branch December 20, 2019 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raphlinus raphlinus raphlinus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmyr @raphlinus