[IMPROVEMENT] Test metrics validity when testing Exporter #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the 'test' button for an exporter, we previously *only* checked the status code and assumed things were good. It is very possible for an incorrect endpoint to be registered, so we should ensure that the registered endpoint produces correct Prometheus metrics. Right now, we will return a somewhat *developer* like output, but I expect to make the output more user friendly as we cleanup some of our internal test URLs.
vincent-olivert-riera
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the 'test' button for an exporter, we previously only checked the status code and assumed things were good. It is very possible for an incorrect endpoint to be registered, so we should ensure that the registered endpoint produces correct Prometheus metrics.
Right now, we will return a somewhat developer like output, but I expect to make the output more user friendly as we cleanup some of our internal test URLs.