Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement flex message feature #107

Merged
merged 2 commits into from
Jun 21, 2018
Merged

Implement flex message feature #107

merged 2 commits into from
Jun 21, 2018

Conversation

be-hase
Copy link
Member

@be-hase be-hase commented Jun 20, 2018

tokuhirom and others added 2 commits June 19, 2018 23:09
@tokuhirom @be-hase
Support flex message. Close line#102 (line#106)
8118344 
* Support flex message. Close line#102

Ref. line/line-bot-sdk-java#198

* fixed test case

* Fixed typo. s/filter/filler/

* follow flake8 rules
@be-hase
Add docstring of flex_message
3a3304a
@be-hase be-hase requested a review from okdtsk June 21, 2018 05:23
okdtsk
okdtsk approved these changes Jun 21, 2018
View reviewed changes
Copy link
Member

@okdtsk okdtsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM 🐱

@okdtsk okdtsk merged commit ccb97de into line:master Jun 21, 2018
@be-hase be-hase deleted the add-docstring branch June 21, 2018 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tokuhirom tokuhirom tokuhirom approved these changes

@okdtsk okdtsk okdtsk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@be-hase @tokuhirom @okdtsk