Support ARCSAT observatory images and add console script #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into some issues using
koffi
out of the box with images from the ARCSAT observatory. I looked into them and implemented some bug fixes and functionality changes so thatkoffi
works with these images and in a workflow suitable for me.The bug fixes are a few typos in the code and when specifying fits headers.
The changes include:
OBSERVAT
header matches an MPC obs-code before using it, falling back to observatory longitude and altitude.DATE-OBS
andEXPTIME
headers to compute the observation time (as observation start + half the exposure time) in caseDATE-AVG
or themjd_key
are not available. (ARCSAT sets theJD
header instead).koffi
can be used as an executable on the command line with reasonable printing, like so:x
andy
are the pixel locations of the objects and are valuable for followup. Note thatkoffi
may want to filter out objects that land outside of the bounds of the CCD, which three of these do with negative pixel values. Machine readable formats can be printed using e.g.--format csv
.