Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: clean up gomodjail comments #3260

Merged
merged 1 commit into from
Feb 18, 2025
Merged

Conversation

AkihiroSuda
Copy link
Member

Before:

module github.com/lima-vm/lima

require (
  github.com/Code-Hex/go-infinity-channel v1.0.0 // indirect; indirect //
gomodjail:confined
  github.com/fsnotify/fsnotify v1.8.0 // indirect
)

After:

// gomodjail:confined
module github.com/lima-vm/lima

require (
  github.com/Code-Hex/go-infinity-channel v1.0.0 // indirect
  // gomodjail:unconfined
  github.com/fsnotify/fsnotify v1.8.0 // indirect
)

The old syntax was causing issues with Dependabot.

Fix #3256

Before:

```go-module
module github.com/lima-vm/lima

require (
  github.com/Code-Hex/go-infinity-channel v1.0.0 // indirect; indirect //
gomodjail:confined
  github.com/fsnotify/fsnotify v1.8.0 // indirect
)
```

After:

```go-module
// gomodjail:confined
module github.com/lima-vm/lima

require (
  github.com/Code-Hex/go-infinity-channel v1.0.0 // indirect
  // gomodjail:unconfined
  github.com/fsnotify/fsnotify v1.8.0 // indirect
)
```

The old syntax was causing issues with Dependabot.

Fix issue 3256

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@AkihiroSuda AkihiroSuda added this to the v1.1 (tentative) milestone Feb 18, 2025
Copy link
Member

@jandubois jandubois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@jandubois jandubois merged commit b55086f into lima-vm:master Feb 18, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

go.mod: apply gomodjail:confined to the global scope
2 participants