Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vz: fix mu #1497

Merged
merged 1 commit into from
Apr 15, 2023
Merged

vz: fix mu #1497

merged 1 commit into from
Apr 15, 2023

Conversation

AkihiroSuda
Copy link
Member

Follow-up to #1494
Fix #1381

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@balajiv113
Copy link
Member

@AkihiroSuda
Changes looks fine for me.

But am trying to understand why mu would be needed here.

We are creating wrapper once and updating the stopped in one place only.
Even if both tick and stateChange happens at same time the tick would fail and stopped would be set to true and on next tick it would technically be successful

Am i missing something here 🤔

@AkihiroSuda AkihiroSuda merged commit 5fe67f0 into lima-vm:master Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

panic: runtime/cgo: misuse of an invalid Handle (Code-Hex/vz/v3.changeStateOnObserver)
2 participants