Check if growpart is installed before calling it #1243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
da1358a to
e4c7ef9
Compare
AkihiroSuda
reviewed
Dec 14, 2022
AkihiroSuda
reviewed
Dec 14, 2022
AkihiroSuda
reviewed
Dec 14, 2022
| # growpart command may be missing in older VMs | ||
| if command -v growpart >/dev/null 2>&1; then | ||
| # Automatically expand the data volume filesystem | ||
| growpart "$DATA_DISK" 1 || true |
There was a problem hiding this comment.
Not new in this PR, but the final exit code of the script should be set to non-zero when growpart fails
There was a problem hiding this comment.
(This can be another PR in the future)
There was a problem hiding this comment.
Why does it make a difference; won't the failure of growpart (or resize2fs) show up in the cloud-init log anyways?
Please file an issue if you think this is really necessary; I won't have time for it until after the holidays, and will probably forget by then...
|
Thanks, confirmed that this fixes #1242 |
Closed
3 tasks
Both `cloud-utils-growpart` (for `growpart`) and `e2fsprogs-extra` (for `resize2fs`) have only been recently added to alpine-lima. Running an existing VM based on an older Alpine ISO will then fail the boot script calling utilities that have not been installed. Signed-off-by: Jan Dubois <jan.dubois@suse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both
cloud-utils-growpart(forgrowpart) ande2fsprogs-extra(forresize2fs) have only been recently added to alpine-lima.Running an existing VM based on an older Alpine ISO will then fail the boot script calling utilities that have not been installed.
Untested, but I believe this
fixes #1242