feat/towards writer extension point #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6074cf5 to
87ed641
Compare
lilydjwg
reviewed
Mar 14, 2024
nvchecker/core.py
Outdated
Comment on lines
415
to
416
| ret[r1.name] = r1.version | ||
| results.append(r1) |
There was a problem hiding this comment.
What about returning data like this:
Suggested change
| ret[r1.name] = r1.version | |
| results.append(r1) | |
| ret[r1.name] = r1 |
In this way we can avoid returning duplicate information in two ways.
1e42ca7 to
883cef6
Compare
883cef6 to
f29bdee
Compare
|
I've also got rid of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--entry#255Context
#253 prototypes a "writer" implementation.
It takes a version result and not only updates references but then also mutates the code base on the basis of the newly obtained references.
A Nix writer is certainly no good in-tree use case.
Hence, this PR tries to conceptualize a potential extension point for downstream packages which could implement writer implementations similarly as, today,
nvfetcher_sourceprovides source implementations.