Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Consolidate the db-service repo into this one #467

Merged
merged 4 commits into from
Jan 26, 2024

Conversation

lijim
Copy link
Owner

@lijim lijim commented Jan 26, 2024

At $7/ month per server, hosting a separate server for https://github.com/lijim/monks-and-mages-db-service and https://github.com/lijim/monks-and-mages-reverse-proxy is becoming a tad expensive.

This PR consolidates the work in the DB service into the main express app so that the main express app serves all static content, hosts the websocket server, and incorporates DB-accessing API calls (such as fetching all decks for a user) into one singular express app

Pros:

  • easier to manage typings if we ever want to share them between services
  • less $ spent to host the site

Cons:

  • If the DB service aspect has a failure, all the websockets will disconnect because of the Node.JS crash

@lijim lijim added this to the Tech Infra Golden Path - v2 milestone Jan 26, 2024
@lijim lijim merged commit b27e2ed into main Jan 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant