Avoid warning from mysqldump when no port is specified

liip · Jun 2, 2019 · d04178c · d04178c
1 parent 17c07b5
commit d04178c
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/src/Services/DatabaseBackup/MysqlDatabaseBackup.php b/src/Services/DatabaseBackup/MysqlDatabaseBackup.php
@@ -71,14 +71,18 @@ public function backup(AbstractExecutor $executor): void
 
         $dbName = isset($params['dbname']) ? $params['dbname'] : '';
         $dbHost = isset($params['host']) ? $params['host'] : '';
-        $dbPort = isset($params['port']) ? $params['port'] : '';
+
+        // Define parameter only if there's a value, to avoid warning from mysqldump:
+        // mysqldump: [Warning] mysqldump: Empty value for 'port' specified. Will throw an error in future versions
+        $port = isset($params['port']) ? '--port='.$params['port'] : '';
+
         $dbUser = isset($params['user']) ? $params['user'] : '';
         $dbPass = isset($params['password']) ? $params['password'] : '';
 
         $executor->getReferenceRepository()->save($this->getBackupFilePath());
         self::$metadata = $em->getMetadataFactory()->getLoadedMetadata();
 
-        exec("MYSQL_PWD=$dbPass mysqldump --host $dbHost --port=$dbPort --user $dbUser --no-create-info --skip-triggers --no-create-db --no-tablespaces --compact $dbName > {$this->getBackupFilePath()}");
+        exec("MYSQL_PWD=$dbPass mysqldump --host $dbHost $port --user $dbUser --no-create-info --skip-triggers --no-create-db --no-tablespaces --compact $dbName > {$this->getBackupFilePath()}");
     }
 
     protected function updateSchemaIfNeed(EntityManager $em)