Make LightStep's Tracer fall in line with OpenTracing changes #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| record.addToJoin_ids(new TraceJoinId(TRACE_GUID_KEY, traceID)); | ||
| SpanContext newSpanContext = new SpanContext(traceId); // traceId may be null | ||
| // Record the eventual TraceId in the SpanRecord. | ||
| record.setTrace_guid(newSpanContext.getTraceId()); |
There was a problem hiding this comment.
we set this rather than the no-longer-needed and deprecated TRACE_GUID_KEY.
|
cc: @bcronin and @kcamenzind I will add inject and join for at least the text format over the weekend, but wanted to get this in first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This keeps the build and tests green after opentracing/opentracing-java#32 . I will explicitly mark the only (intentional!) changes to functionality.