Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

limit number of log events #46

Closed
RaduBerinde opened this issue Sep 26, 2016 · 1 comment
Closed

limit number of log events #46

RaduBerinde opened this issue Sep 26, 2016 · 1 comment

Comments

@RaduBerinde
Copy link
Contributor

We had an issue where a bug was causing endless retries and the memory inside basictracer grew indefinitely. It would be great if there was an option to only keep the last X log events inside a span.

Assuming we implement this functionality in basictracer, would it be ok with lightstep to pass along that option? (similar to how we pass DropSpanLogs)
@bhs
Copy link
Contributor

bhs commented Sep 26, 2016

@RaduBerinde

Assuming we implement this functionality in basictracer, would it be ok with lightstep to pass along that option? (similar to how we pass DropSpanLogs)

Yes. Thanks.

RaduBerinde added a commit to RaduBerinde/lightstep-tracer-go that referenced this issue Sep 29, 2016
@RaduBerinde
Add MaxLogsPerSpan option
e7c4895 
Basictracer now supports a `MaxLogPerSpan` options; plumbing this option in
Lightstep as well.

Fixes lightstep#46.
@RaduBerinde RaduBerinde mentioned this issue Sep 29, 2016
Merged
RaduBerinde added a commit to RaduBerinde/lightstep-tracer-go that referenced this issue Sep 30, 2016
@RaduBerinde
Add MaxLogsPerSpan option
0944454 
Basictracer now supports a `MaxLogPerSpan` option; plumbing this option in
Lightstep as well.

Fixes lightstep#46.
RaduBerinde added a commit to RaduBerinde/lightstep-tracer-go that referenced this issue Sep 30, 2016
@RaduBerinde
Add MaxLogsPerSpan option
f9e89e3 
Basictracer now supports a `MaxLogPerSpan` option; plumbing this option in
Lightstep as well.

Fixes lightstep#46.
@bhs bhs closed this as completed in #47 Oct 1, 2016
bhs pushed a commit that referenced this issue Oct 1, 2016
@RaduBerinde @bensigelman
Add MaxLogsPerSpan option (#47)
7ec5005 
Basictracer now supports a `MaxLogPerSpan` option; plumbing this option in
Lightstep as well.

Fixes #46.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bhs @RaduBerinde