Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Storybook & Percy, (partially) remove Sass from stories #7

Merged
merged 5 commits into from
Sep 26, 2019
Merged

Update Storybook & Percy, (partially) remove Sass from stories #7

merged 5 commits into from
Sep 26, 2019

Conversation

xdrdak
Copy link
Contributor

@xdrdak xdrdak commented Sep 23, 2019 •
edited by glambert
Loading

Description

Newest storybook has some pretty substantial performance improvements. I also needed to use the newer version of percy for storybook, which means shifting things around left and right.

I've also taken the time to slowly phase out any sass related stuff from our storybook.

How to test?

  • Checkout branch, run yarn dev
  • Open Storybook
  • Or check the deploy preview on Netlify (link available in comments)

Checklist

@xdrdak xdrdak requested a review from a team as a code owner September 23, 2019 19:34
@github-actions github-actions bot added chore dependencies Pull requests that update a dependency file labels Sep 23, 2019
@netlify
Copy link

netlify bot commented Sep 23, 2019 •
edited
Loading

Deploy preview for lightspeed-flame ready!

Built with commit 97f8d62

https://deploy-preview-7--lightspeed-flame.netlify.com

@xdrdak xdrdak force-pushed the update-storybook-and-use-globalstyle-component branch from c326fea to e1fcd42 Compare September 24, 2019 16:07
glambert
glambert approved these changes Sep 25, 2019
View reviewed changes
Copy link
Collaborator

@glambert glambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Visual changes caught by Percy are minor and unrelated to components (mainly spacing changes). LGTM 🎉

@glambert glambert mentioned this pull request Sep 25, 2019
Open
@glambert glambert changed the title Update Storybook & Percy. Cleanup SASS stuff Update Storybook & Percy, (partially) remove Sass from stories Sep 25, 2019
@xdrdak xdrdak merged commit 5e42c90 into master Sep 26, 2019
@xdrdak xdrdak deleted the update-storybook-and-use-globalstyle-component branch September 26, 2019 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glambert glambert glambert approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xdrdak @glambert