Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpc: add default conf target back #8693

Merged
merged 2 commits into from
Apr 26, 2024
Merged

rpc: add default conf target back #8693

merged 2 commits into from
Apr 26, 2024

Conversation

yyforyongyu
Copy link
Member

The itest has been reverted to test the default behavior.

@yyforyongyu yyforyongyu self-assigned this Apr 25, 2024
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Apr 25, 2024

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

yyforyongyu
yyforyongyu commented Apr 25, 2024
View reviewed changes
docs/release-notes/release-notes-0.18.0.md
`SatPerVbyte` and `TargetConf`, and a default conf target of 6 will be used.
This will [no longer be
allowed](https://github.com/lightningnetwork/lnd/pull/8422) in the next
release (v0.19.0) and the caller must specify either `SatPerVbyte` or
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @saubyk do you think it's feasible to enforce this in the next release, or should we wait even longer, say 0.20.0?

Copy link
Collaborator

@saubyk saubyk Apr 25, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that we realized the impact at a later stage in the game, here's my recommendation:

  • Deprecate the rpcs in 0.19 and publish a new set of rpcs (v2/v3) which would require user to specify the fee rate
  • remove the deprecated rpcs in 0.20 forcing the users to move to the new rpcs
  • EDIT: Also gives enough time to apps/wallets to update their interfaces

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think adding a new set of RPC endpoints because of one field is an overkill. Normally we'd add a deprecated flag to the existing field.

@saubyk saubyk added this to the v0.18.0 milestone Apr 25, 2024
@Roasbeef
Copy link
Member

Itests are unhappy ☹️, looks like it's from:

--- FAIL: TestLightningNetworkDaemon/tranche00/11-of-149/bitcoind/sweep_coins

Roasbeef
Roasbeef requested changes Apr 25, 2024
View reviewed changes
lntest/harness.go Outdated Show resolved Hide resolved
rpcserver.go Show resolved Hide resolved
rpcserver.go
// Keep the old behavior prior to 0.18.0 - when the user
// doesn't set fee rate or conf target, the default conf target
// of 6 is used.
targetConf := maybeUseDefaultConf(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we should just push this logic into CalculateFeeRate? Then we just need to remember to use that function, instead of sprinkling this additional function call everywhere.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah initially did that then realized there's no logging in that package so took the easy path😂 let me know if you wanna enable logging in lnrpc.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh lol, yeah np to add logging here IMO.

Roasbeef
Roasbeef approved these changes Apr 26, 2024
View reviewed changes
Copy link
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🦚

@Roasbeef Roasbeef merged commit 675ae6e into lightningnetwork:master Apr 26, 2024
23 of 27 checks passed
@yyforyongyu yyforyongyu deleted the add-default-conf branch July 24, 2024 10:21
@yyforyongyu yyforyongyu mentioned this pull request Jul 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saubyk saubyk saubyk left review comments

@Roasbeef Roasbeef Roasbeef approved these changes

Assignees

@yyforyongyu yyforyongyu

Labels
None yet
Projects
lnd v0.18
Status: ✅ Done
Milestone
v0.18.0
Development

Successfully merging this pull request may close these issues.
3 participants
@yyforyongyu @Roasbeef @saubyk