Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lnrpc: ensure parsing of the Amp flag for payments is consistent #8681

Merged
merged 1 commit into from
Apr 26, 2024
Merged

lnrpc: ensure parsing of the Amp flag for payments is consistent #8681

merged 1 commit into from
Apr 26, 2024

Conversation

Roasbeef
Copy link
Member

In this commit, we fix an inconsistent in the API related to AMP payments. When a payment request isn't specified, we require the --amp flag on the CLI to make an AMP payment. However, for payment requests, we don't require this flag. To fix this inconsistency, we now require the --amp flag to also be set for payment requests.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Apr 24, 2024

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@saubyk saubyk requested review from a team, bhandras and yyforyongyu and removed request for a team April 24, 2024 01:44
@saubyk saubyk added this to the v0.18.0 milestone Apr 24, 2024
saubyk
saubyk approved these changes Apr 24, 2024
View reviewed changes
Copy link
Collaborator

@saubyk saubyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concept Ack

@Roasbeef Roasbeef force-pushed the amp-flag-consistency branch from 5885f1d to 7c39a8c Compare April 24, 2024 01:50
@ziggie1984 ziggie1984 self-requested a review April 24, 2024 15:26
@yyforyongyu
Copy link
Member

itest failed 😢

@Roasbeef Roasbeef force-pushed the amp-flag-consistency branch from 7c39a8c to cb82739 Compare April 24, 2024 23:34
@Roasbeef
Copy link
Member Author

Missed a spot to add the flag in the itests. Added a new functional opt to modify one of the send payment calls. Should be g2g now.

ziggie1984
ziggie1984 approved these changes Apr 25, 2024
View reviewed changes
Copy link
Collaborator

@ziggie1984 ziggie1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⭐️, pending Linter Fix

@saubyk saubyk requested review from yyforyongyu and removed request for bhandras and yyforyongyu April 25, 2024 02:08
@guggero
Copy link
Collaborator

guggero commented Apr 25, 2024

Future drive-by contributors will have a hard time finding typos to fix since the linter now also points them out 😂
Also, needs a rebase because of the release notes.

@Roasbeef
lnrpc: ensure parsing of the Amp flag for payments is consistent
e8031fd 
In this commit, we fix an inconsistent in the API related to AMP
payments. When a payment request isn't specified, we require the `--amp`
flag on the CLI to make an AMP payment. However, for payment requests,
we don't require this flag. To fix this inconsistency, we now require
the `--amp` flag to _also_ be set for payment requests.
@Roasbeef Roasbeef force-pushed the amp-flag-consistency branch from cb82739 to e8031fd Compare April 25, 2024 23:16
@Roasbeef
Copy link
Member Author

Typo fixed! Will land assuming CI agrees.

@Roasbeef Roasbeef merged commit e6d6789 into lightningnetwork:master Apr 26, 2024
23 of 27 checks passed
@guggero guggero mentioned this pull request May 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saubyk saubyk saubyk approved these changes

@ziggie1984 ziggie1984 ziggie1984 approved these changes

@yyforyongyu yyforyongyu Awaiting requested review from yyforyongyu

Assignees

@Roasbeef Roasbeef

Labels
amp api bug fix
Projects
lnd v0.18
Status: ✅ Done
Milestone
v0.18.0
Development

Successfully merging this pull request may close these issues.
5 participants
@Roasbeef @yyforyongyu @guggero @saubyk @ziggie1984