-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kvdb: embedded postgres upgrade to allow setting a custom max_connections
config value
#8419
kvdb: embedded postgres upgrade to allow setting a custom max_connections
config value
#8419
Conversation
Important Auto Review SkippedAuto reviews are limited to the following labels: llm-review. Please add one of these labels to enable auto reviews. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
8c3c99e
to
560ea95
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Will we hit the limit any time soon? If I am not confused embedded Postgres runs each test in its own database inside the same Postgres.
I guess the assumption here is that we will never run >200 tests using the DB concurrently?
Thanks for the review Jordi! :) I think we'll probably just go lower from here as we migrate away from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🐦
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack
Change Description
This PR updates the embedded postgres dependency in the
kvdb
package to the latest tagged version (v1.25.0). This new version allows for setting themax_connection
config value when starting the underlying Postgres instance. We parallelize some DB tests in #8100 which exhausts the connection limits so this PR is a pre-requirement for that.