CI: upgrade bitcoind version to 25 #8386
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9a61f1a to
8a51915
Compare
We remove the env variable used in workflows and specify the version in a single file to make sure we won't misconfig again.
8a51915 to
c6e48be
Compare
yyforyongyu
commented
Jan 16, 2024
| @@ -2,9 +2,9 @@ | |||
|
|
|||
| set -ev | |||
|
|
|||
| BITCOIND_VERSION=${BITCOIN_VERSION:-25.0} | |||
| BITCOIND_VERSION=25 | |||
There was a problem hiding this comment.
Would prefer to set it to 25.0, but it won't work as our images are tagged as bitcoin-core:25, tho it looks like it used to be tagged differently, eg, lightninglabs/bitcoin-core:23.0
bitcoind v25.0 updated the `sendrawtransaction` RPC to have an optional argument `maxburnamount` with a default value of 0. This means our existing test that uses burning output cannot be published, hence, we remove the usage of it in our tests and replace it with a normal tx.
f93120e to
6f49073
Compare
|
just realized it's a dup of #8273 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We remove the env variable used in workflows and specify the version in a single file to make sure we won't misconfig again.