recreate rpc.pb.go #1601
Closed
recreate rpc.pb.go #1601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See #1467. Until that's merged, you'll need to use the versions that are specified in the contribution guidelines: https://github.com/lightningnetwork/lnd/blob/master/docs/code_contribution_guidelines.md#456-protobuf-compilation |
maurycy
reviewed
Jul 23, 2018
lnrpc/rpc.swagger.json
Outdated
| @@ -17,7 +17,8 @@ | |||
| "paths": { | |||
| "/v1/balance/blockchain": { | |||
| "get": { | |||
| "summary": "* lncli: `walletbalance`\nWalletBalance returns total unspent outputs(confirmed and unconfirmed), all\nconfirmed unspent outputs and all unconfirmed unspent outputs under control\nof the wallet.", | |||
| "summary": "*\nGenSeed is the first method that should be used to instantiate a new lnd\ninstance. This method allows a caller to generate a new aezeed cipher seed\ngiven an optional passphrase. If provided, the passphrase will be necessary\nto decrypt the cipherseed to expose the internal wallet seed.", | |||
There was a problem hiding this comment.
Interesingly, it has the same problem as #1467 (diff) that indicates there is something wrong with our proto files.
cc @wpaulino
|
I ran |
|
Closing, as the changes are insignificant at this point. Thanks for the heads up though, we'll make sure this becomes consistent once we have updated to the newet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got some diff when I tried to execute
lnrpc/gen_protos.sh.I used libprotoc 3.6.0 for OSX.