Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tapchannel: fix proof courier initialization #1058

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Conversation

guggero
Copy link
Member

@guggero guggero commented Aug 5, 2024

Fixes #1057 by making sure the proof courier's Recipient struct is properly populated, preventing a nil pointer panic when a HashMail courier is used.

@guggero guggero requested review from Roasbeef and GeorgeTsagk August 5, 2024 08:33
Copy link
Member

@GeorgeTsagk GeorgeTsagk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢

Copy link
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🛟

tapchannel/aux_sweeper.go Show resolved Hide resolved
Fixes #1057 by making sure the proof courier's Recipient struct is
properly populated, preventing a nil pointer panic when a HashMail
courier is used.
@guggero guggero force-pushed the proof-courier-null-fix branch from c7b28d6 to 8164782 Compare August 6, 2024 07:26
@guggero guggero merged commit ae0f1ce into main Aug 6, 2024
16 checks passed
@guggero guggero deleted the proof-courier-null-fix branch August 6, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

[bug]: Null pointer when closing traproot-assets channel in regtest
3 participants