Store transfer output proof delivery status #1035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jharveyb
approved these changes
Jul 23, 2024
@jharveyb Thanks for the review. Yes, will definitely get done. I was thinking in a follow up PR. |
guggero
requested changes
Jul 24, 2024
tapdb/sqlc/migrations/000022_transfer_outputs_proof_delivered.down.sql
Outdated
Show resolved
Hide resolved
f11dc88 to
696261d
Compare
guggero
reviewed
Jul 26, 2024
tapdb/sqlc/migrations/000022_transfer_outputs_proof_delivered.down.sql
Outdated
Show resolved
Hide resolved
Add the `proof_delivery_complete` and `position` columns to the `asset_transfer_outputs` table. The `position` column indicates the position of the output in the transfer output list. The position and anchor outpoint uniquely identify a transfer output. This change updates the row insertion and retrieval SQL statements for this table. Additionally, new SQL statements are included for modifying these new columns.
ShouldDeliverProof returns true if a proof corresponding to the subject transfer output should be delivered to a peer.
Set and retrieve the `proof_delivery_complete` and `position` columns from the `asset_transfer_outputs` table.
Refactors the `transferReceiverProof` method in `ChainPorter` by utilizing the new `ShouldDeliverProof` method for transfer output. This change simplifies the method's implementation. Note: This refactoring is not related to the primary objectives of this series of commits.
Add a `ConfirmProofDelivery` method to the export log. This function is called after a proof has been successfully delivered to a remote peer.
This commit introduces a unit test for the `SetTransferOutputProofDeliveryStatus` functionality to ensure proof delivery confirmation.
696261d to
25f0aba
Compare
jharveyb
reviewed
Jul 29, 2024
|
|
||
| // Check if position value can be stored in a 32-bit integer. Type cast | ||
| // if possible, otherwise return an error. | ||
| if output.Position > math.MaxInt32 { |
There was a problem hiding this comment.
See note elsewhere re: switching to int64.
Roasbeef
reviewed
Jul 29, 2024
| ADD COLUMN proof_delivery_complete BOOL; | ||
|
|
||
| -- Add column `position` which indicates the index of the output in the list of | ||
| -- outputs for a given transfer. This index position in conjunction with the |
There was a problem hiding this comment.
Couldn't we just use the existing primary key for this?
|
|
||
| // If this is an output that is going to our own node/wallet, we don't | ||
| // need to deliver a proof. | ||
| if out.ScriptKey.TweakedScriptKey != nil && out.ScriptKeyLocal { |
There was a problem hiding this comment.
We should double check this with some of the litd itests we have for channels. At times, we verify that a proof was uploaded even if it was a local script key.
|
|
||
| // If the script key is a burn key, we don't need to deliver a proof. | ||
| if len(out.WitnessData) > 0 && asset.IsBurnKey( | ||
| out.ScriptKey.PubKey, out.WitnessData[0], |
There was a problem hiding this comment.
Aren't burns still relevant? So to proof to someone that you've burnt an asset.
|
|
||
| // Burns are also always kept local and not sent to any | ||
| // receiver. | ||
| if len(out.WitnessData) > 0 && asset.IsBurnKey( |
There was a problem hiding this comment.
Ah I see this was also just existing behavior, feel free to ignore those other comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is work towards fixing #1009 (making the proof transfer process more robust).
This pull request adds a new
proof_deliver_completecolumn to theasset_transfer_outputstable. It includes updates to the table schema, modifications to SQL statements, and adjustments to unit tests. Additionally, it integrates changes to thetapfreightercomponent for logging proof delivery confirmations.Changes
Schema Update:
proof_deliver_completecolumn to theasset_transfer_outputstable.SQL Statement Modifications:
proof_deliver_completecolumn.proof_deliver_completecolumn.Field Population:
proof_deliver_completefield for new transfer output rows.proof_deliver_completefield is populated when reading from the database.Proof Delivery Logging:
ConfirmProofDeliverymethod to thetapfreighterexport log.ConfirmProofDeliveryfunction is called after a proof has been successfully delivered to a remote peer.Unit Test Adjustment: