Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add list swaps filter #679

Merged
merged 3 commits into from
Jan 4, 2024
Merged

Add list swaps filter #679

merged 3 commits into from
Jan 4, 2024

Conversation

sputn1ck
Copy link
Member

This PR adds the option to filter swaps in the listswaps command by:

  • swap type (loop in/loop out)
  • pending
  • label
  • outgoing channel set (if loop in)
  • last hop (if loop out)

closes #678

@sputn1ck sputn1ck mentioned this pull request Dec 23, 2023
Closed
markettes
markettes approved these changes Dec 23, 2023
View reviewed changes
Copy link

@markettes markettes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bhandras
bhandras approved these changes Jan 2, 2024
View reviewed changes
Copy link
Member

@bhandras bhandras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice addition! 🎉

GeorgeTsagk
GeorgeTsagk approved these changes Jan 2, 2024
View reviewed changes
Copy link
Member

@GeorgeTsagk GeorgeTsagk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@sputn1ck sputn1ck merged commit 52135a4 into lightninglabs:master Jan 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhandras bhandras bhandras approved these changes

@markettes markettes markettes approved these changes

@GeorgeTsagk GeorgeTsagk GeorgeTsagk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Filter listswaps by different parameters
4 participants
@sputn1ck @bhandras @markettes @GeorgeTsagk