frdrpc: rename proto, use Docker for compilation, move to GitHub CI #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlaKC
approved these changes
Apr 6, 2021
frdrpc/Dockerfile
Outdated
| ARG PROTOC_GEN_VERSION | ||
| ARG GRPC_GATEWAY_VERSION | ||
|
|
||
| ENV FALAFEL_VERSION="v0.7.1" |
There was a problem hiding this comment.
FALAFEL_VERSION unnecessary?
There was a problem hiding this comment.
Correct, obviously this isn't needed 😅
| @@ -21,4 +21,4 @@ require ( | |||
| gopkg.in/macaroon.v2 v2.1.0 | |||
| ) | |||
|
|
|||
| go 1.13 | |||
| go 1.15 | |||
There was a problem hiding this comment.
nit: commit message doesn't quite fit, since we're bumping min version and docker versions to different values
Because the file name "rpc.proto" is already taken by lnd, we get a weird warning everywhere we include both the lnd and faraday, as libraries for example: WARNING: proto: file "rpc.proto" is already registered We fix this problem by renaming faraday's proto file.
To simplify the RPC generation and make it easier for people to compile the faraday.proto file, we extract the REST definitions into their own file.
To make the protobuf and grpc versions used in Faraday independent of those in lnd, we compile the protos inside a container. Therefore the local development environment doesn't have to match any other project in terms of those versions for successful compilation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main purpose of the PR is to rename
rpc.prototofaraday.protoin an attempt to get rid of the errorWARNING: proto: file "rpc.proto" is already registeredwe see wherever we use both Faraday as well aslndas libraries.While we're at it, we also use Docker for compiling the RPC protos, update the golang version and move the CI pipeline to GitHub.