backup: Rewrite erroneously expanded SQL stmts on-the-fly #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems to have little to no performance impact.
m-schmoock
reviewed
Dec 1, 2020
There was a problem hiding this comment.
ACK 5557bef
Kinda overkill for a bug that's already been fixed imho, but why not :D
|
|
||
| for i, o in tests: | ||
| assert(b._rewrite_stmt(i) == o) | ||
|
|
There was a problem hiding this comment.
Nit: E302 missing one more blank line :D
| ( | ||
| r'UPDATE outputs SET status=123, reserved_til=1891733WHERE prev_out_tx=1 AND prev_out_index=2', | ||
| r'UPDATE outputs SET status=123, reserved_til=1891733 WHERE prev_out_tx=1 AND prev_out_index=2', | ||
| ), |
There was a problem hiding this comment.
Nit: you could also test for the second statement: ... peer_id=12345WHERE channels.id...
The issue is that users still have backups that predate the fix, so we need a way for them to restore those backups. Eventually we can retire this things, but for now it's required. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite queries that predate ElementsProject/lightning#4090 to include
the missing whitespace. Doing this on-the-fly seems to have little to
no impact on performance, so let's just do it this way. Has the
advantage of working transparently for the user.
Fixes #158