Clarify nonce size for onion cipher #849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some ChaCha20 implementations API's support both 64- and 96-bit nonces, while others only support a single one. Functionally, both nonce sizes are equivalent for LN usage, since the nonce is always zeroed. However, while evaluating spec compliance of ChaCha20 libraries, the fact that some do not support the 8 byte nonce variant prompted a closer investigation about the nonce requirement. Since RFC8439 is the one linked to in the current BOLT0004 spec and that RFC only specifies the 96-bit nonce variant, that requirement is made more explicit by this commit.
t-bast
reviewed
Feb 18, 2021
19 tasks
|
Oh nice one, we are using libsodium which takes 64bits, hence the implicit assumption in my writeup. ACK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some ChaCha20 implementations API's support both 64- and 96-bit nonces, while
others only support a single one.
Functionally, both nonce sizes are equivalent for LN usage, since the
nonce is always zeroed. However, while evaluating spec compliance of
ChaCha20 libraries, the fact that some do not support the 8 byte nonce
variant prompted a closer investigation about the nonce requirement.
Since RFC8439 is the one linked to in the current BOLT0004 spec and that
RFC only specifies the 96-bit nonce variant, that requirement is made
more explicit by this commit.