BOLT 10 copy edit #440
BOLT 10 copy edit #440
Conversation
10-dns-bootstrap.md
Outdated
| - `a`: address types | ||
| - used to specify what address types should be returned for `SRV` queries | ||
| - a bitfield that uses the types from [BOLT #7](07-routing-gossip.md) as bit | ||
| index |
There was a problem hiding this comment.
I think swapping bullet points 1 and 2 will result in a clearer read.
There was a problem hiding this comment.
(And it's more consistent with the l description.)
10-dns-bootstrap.md
Outdated
| - default value: 6 (i.e. `2 || 4`, since bit 1 and bit 2 are set for IPv4 and | ||
| IPv6, respectively) | ||
| - `l`: `node_id` | ||
| - bech32-encoded `node_id` of a specific node |
There was a problem hiding this comment.
Prefacing this with "a" will make it more consistent with the r description
10-dns-bootstrap.md
Outdated
| - MUST evaluate the conditions from the _seed root domain_ by | ||
| 'going up-the-tree', i.e. evaluating right-to-left in a fully qualified domain | ||
| name. | ||
| - E.g. evaluate the above case: first `n10`, then `a2`, and finally `r0`. |
There was a problem hiding this comment.
Perhaps: "to evaluate the above case: first evaluate n10, then a2, and finally r0.
There was a problem hiding this comment.
better, thanks!
10-dns-bootstrap.md
Outdated
| Should no entries match all the conditions then an empty reply MUST be returned. | ||
| The DNS seed: | ||
| - MAY additionally return the corresponding `A` and `AAAA` records that | ||
| indicate the IP address for the `SRV` entries in the Extra section [FIXME: not sure what this refers to, is 'Extra section' defined elsewhere?] of the reply. |
There was a problem hiding this comment.
Me too.... @cdecker ?
There was a problem hiding this comment.
The additional section in RFC 1035 allows us to return results whose type does not match the query type. This is commonly used to piggyback the A record together with the reply for an MX record. Otherwise the client would have to issue two queries (a) "give me the name of the server", and (b) "now tell me where to find that name". In our case SRV returns only names, not the matching addresses, so we just add them in the additional section.
There was a problem hiding this comment.
And yes, I misnamed the section in the original draft :-)
|
Excellent changes, if you fix my misnaming of the "additional section" I'm more than happy to merge this asap. |
|
@cdecker done, thanks. |
Copy edit BOLT10 to bring in line with stylesheet guidelines