Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to scaladocs when javadoc link is not found #58

Merged
merged 1 commit into from
Sep 4, 2019

Conversation

2m
Copy link
Contributor

@2m 2m commented Sep 2, 2019

This PR builds on top of #57 therefore still a draft.

When a javadoc base url is not configured in paradox properties, instead of throwing an exception, now a scaladoc link is generated.

This is useful for linking to projects, that do not publish javadoc.

Fixes #16

Copy link
Member

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@2m 2m force-pushed the wip-scaladoc-for-java-class-2m branch from ca7afff to fd7e276 Compare September 3, 2019 14:06
@2m 2m force-pushed the wip-scaladoc-for-java-class-2m branch from fd7e276 to 3bbf65a Compare September 3, 2019 14:13
@2m 2m merged commit 695d446 into lightbend:master Sep 4, 2019
@2m 2m added this to the 0.3 milestone Sep 4, 2019
@2m 2m deleted the wip-scaladoc-for-java-class-2m branch September 4, 2019 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow linking to javadsl classes but in scaladoc
2 participants