Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception while trying to resolve link for github that contains placeholders #212

Merged
merged 3 commits into from
Jun 24, 2018

Conversation

2m
Copy link
Contributor

@2m 2m commented Jun 21, 2018

There is currently a regression in just released 0.3.4 where an exception is being thrown when a snippet path contains a placeholder. A workaround is to disable github links wtih "snip.github_link" -> "false" in paradoxProperties.

@jonas
Copy link
Contributor

jonas commented Jun 21, 2018

Eeh, this also reveals a bug where we are not actually building anything on Travis. 😱
Created #214

@2m 2m force-pushed the wip-github-with-placeholders-2m branch from 83337a3 to a4bcd99 Compare June 22, 2018 07:15
@2m 2m force-pushed the wip-github-with-placeholders-2m branch from a4bcd99 to b2c06f6 Compare June 22, 2018 13:45
@2m
Copy link
Contributor Author

2m commented Jun 22, 2018

Pushed a fix.

@2m 2m force-pushed the wip-github-with-placeholders-2m branch from b107a3f to 9366987 Compare June 22, 2018 14:40
@2m 2m merged commit c0ce819 into lightbend:master Jun 24, 2018
@2m 2m deleted the wip-github-with-placeholders-2m branch June 24, 2018 10:42
@2m 2m added this to the 0.3.5 milestone Jun 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants