Allow adding classes to snippets #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonas
reviewed
Feb 7, 2018
| |</div>""") | ||
| |@@snip[example2.java](core/src/test/scala/com/lightbend/paradox/markdown/example2.java){ #example2 .red .blue } | ||
| |""") shouldEqual html(""" | ||
| |<pre class="prettyprint red blue"> |
There was a problem hiding this comment.
It would be nice to also propagate the id for completeness.
There was a problem hiding this comment.
The confusing thing is the id is already also used to select the part of the file that needs to be included in the snippet. Would it make sense to also put it on the enclosing pre as id?
There was a problem hiding this comment.
Oh, true. Didn't think about that. It could make sense, but on the other hand it is not necessarily unique in the package.
There was a problem hiding this comment.
Right, probably safer to leave it be indeed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.