Cross build paradox for sbt 0.13 and 1.0 #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
References #134 |
ktoso
reviewed
Sep 19, 2017
ktoso
approved these changes
Sep 19, 2017
raboof
reviewed
Sep 19, 2017
| }}, | ||
| crossSbtVersions := Seq("0.13.16", "1.0.0"), | ||
| // fixed in https://github.com/sbt/sbt/pull/3397 (for sbt 0.13.17) | ||
| sbtBinaryVersion in update := (sbtBinaryVersion in pluginCrossBuild).value, |
There was a problem hiding this comment.
Thanks for finding this, I've ran into this as well 👍 :)
There was a problem hiding this comment.
Yes, thanks a lot indeed. Used for scalacenter/scalajs-bundler#179
There was a problem hiding this comment.
All credit for that should go to @pvlugter who found it and did the workaround for sbt/sbt-javaagent#9
I can only aspire to reach the same level of sbt-fu!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.