Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GitHub directive to support line numbers #143

Merged
merged 2 commits into from
Sep 19, 2017

Conversation

jonas
Copy link
Contributor

@jonas jonas commented Sep 10, 2017

@jonas jonas force-pushed the github-line-number branch from 9c9ca52 to 8817520 Compare September 11, 2017 19:48
@jonas
Copy link
Contributor Author

jonas commented Sep 11, 2017

I managed to pull off the solution mentioned here akka/akka-http#1416 (comment) so it is possible to link to a snippet label and ensure the file exists and that line numbers don't get out of date.

@github[example](/src/test/scala/ServerSetup.scala) { #ssl-setup }

@jonas jonas force-pushed the github-line-number branch from 8817520 to a747886 Compare September 12, 2017 13:52
@jonas
Copy link
Contributor Author

jonas commented Sep 13, 2017

One nice to have for the GitHub tree paths, is to check if the path exists iff in the GitHub tree URL (i.e. /tree/$version) matches project.version or points to master. Does this make sense?

Copy link
Member

@pvlugter pvlugter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@pvlugter pvlugter merged commit 7246a2f into lightbend:master Sep 19, 2017
@jonas jonas deleted the github-line-number branch September 19, 2017 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants