-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add @@dependency directive #142
Conversation
Akka HTTP also uses |
Shows tabbed build tool snippets for using a JVM library.
8ffc02f
to
2736a34
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good! Where did you come across CrossVersion
usage in Akka Http docs?
Several places when referring to the Akka HTTP artifacts. I guess it is for when it's compiled against a Scala RC version. Would it make sense to try to match Scala RC versions in the artifact name like here? |
I see. I was searching for a wrong thing.
I am wondering if we should match the Scala version from the build itself,
instead from the artifact name. It would save many search and replaces when
updating Scala version.
And yes, it does make sense to move the crossversion logic here.
…On Mon, Sep 4, 2017, 16:00 Jonas Fonseca ***@***.***> wrote:
Several places
<https://github.com/akka/akka-http/search?utf8=%E2%9C%93&q=crossString&type=>
when referring to the Akka HTTP artifacts. I guess it is for when it's
compiled against a Scala RC version. Would it make sense to try to match
Scala RC versions in the artifact name like here
<https://github.com/akka/akka-http/blob/master/build.sbt#L166-L169>?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#142 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAZwxj3Bu--Bc5g-DJP7PbzIw5q6iP-2ks5sfAJlgaJpZM4PKSZX>
.
|
I am curious about the default case:
For this example the sbt output would contain a single What do you think if we would have |
I think it will be too error prone if we default to append the Scala binary version to the artifact name. In addition to having something special for java libs you'd also need something special when artifacts are versioned with For Scala dependencies this is pretty clear, yes it adds a bit of noise for the artifact, but it has less chance of doing the wrong thing:
The sbt snippet will show it as |
Great! I did not realise that we will be able to use |
This looks great, LGTM; One problematic thing is that sometimes we need to show multiple dependencies and would be nice to do so in the same snippet. Perhaps that could be a new directive that would be " |
Yes, in Akka HTTP there's one such case, I believe. @ktoso do you have any suggestions on how the syntax should be? I am not sure if the directive syntax parsing can be nested. |
Shows tabbed build tool snippets for using a JVM library.
Alpakka has quite a lot of these and Akka HTTP is starting to as well so it might be good to have a special directive for rendering this.