Direct scaladoc links #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jonas
commented
May 17, 2017
- Fix Scaladocs should link directly to the page, not to the index #104 by linking directly to Scaladoc class and package pages.
- Clarify how to link to a Scaladoc package page
Since at least Scala 2.10, Scaladoc redirects to the framed version automatically when visiting the page directly. Linking directly to the page helps SEO, is friendly to crawlers, and also works when javascript is disabled. Finally, Scala 2.10, 2.11 and 2.12 links can be generated the same way.
jonas
commented
May 17, 2017
| } | ||
|
|
||
| it should "handle method links correctly" in { | ||
| markdown("@scaladoc[???](scala.Predef$@???:Nothing)") shouldEqual | ||
| html("""<p><a href="http://www.scala-lang.org/api/2.11.8/#scala.Predef$@???:Nothing">???</a></p>""") | ||
| markdown("@scaladoc[???](scala.Predef$#???:Nothing)") shouldEqual |
There was a problem hiding this comment.
Note this changes the URLs for linking to methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.