Switch from "sleigh" to "ghidra" for include directory #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This only affects header files from upstream Ghidra repository. Instead of `include <sleigh/header.hh>` it will now be `include <ghidra/header.hh>` for headers from upstream.
38688be to
e4cfc93
Compare
|
If we want to merge this, it should be done before making a release for Ghidra 11.0. At least it will be in line with Ghidra's major version increment to signal breaking changes (even if upstream isn't actually making this breaking change. |
tetsuo-cpp
reviewed
Dec 29, 2023
tetsuo-cpp
approved these changes
Dec 29, 2023
ekilmer
commented
Dec 29, 2023
ekilmer
commented
Dec 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only affects header files from upstream Ghidra repository.
Instead of
#include <sleigh/header.hh>it will now be#include <ghidra/header.hh>for headers from upstream.closes #216
related to open upstream PR NationalSecurityAgency/ghidra#5950